Added option for responsive offcanvas #1246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
#849 proposed to suppress the default class and I did see there is already PR #859 which adds |
Added data-bs-target with ID, as in Bootstrap example for responsive https://getbootstrap.com/docs/5.3/components/offcanvas/#responsive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsive offcanvas was added in Bootstrap v5.2.0 and requires replacing the standard
.offcanvasclass with a breakpoint specific class.https://getbootstrap.com/docs/5.3/components/offcanvas/#responsive
This PR adds a new parameter
Responsiveof typeOffcanvasResponsive(enum) to theOffcanvascomponent. Via this new parameter the desired class will be added similar to howPlacementworks.Resolves #849